Skip to content

Record element type of first element in LazyDynaList.transform - #434

Open
rootvector2 wants to merge 2 commits into
apache:masterfrom
rootvector2:lazydynalist-element-type
Open

Record element type of first element in LazyDynaList.transform#434
rootvector2 wants to merge 2 commits into
apache:masterfrom
rootvector2:lazydynalist-element-type

Conversation

@rootvector2

Copy link
Copy Markdown
Contributor

transform never records the element type for the first non-null element, so the homogeneity check at the end of the method is dead code and mismatched types are silently accepted (add(new HashMap<>()) then add("a POJO String") is accepted), and toArray()/toDynaBeanArray() throw NullPointerException from Array.newInstance(elementType, size()) because elementType stays null; found while auditing the lazy dyna utilities, fixed by recording the type from the first populated element, mirroring setElementDynaClass, which also restores the documented Map[] round-trip in Example 1.

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

@garydgregory garydgregory changed the title record element type of first element in LazyDynaList.transform Record element type of first element in LazyDynaList.transform Aug 12, 2026

@garydgregory garydgregory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rootvector2

Thank you for the PR. What about adding tests for:

  • POJO first element -> WrapDynaBean path, toArray() returning the POJO class and toDynaBeanArray() returning WrapDynaBean[].
  • DynaBean first element -> elementType = DynaBean subclass, elementDynaBeanType = same subclass.
  • addAll(Collection) and addAll(int,Collection) with an untyped list.
  • get/growList after type has been fixed by first population.
  • toDynaBeanArray() type correctness for the untyped case.

TY!

@rootvector2

Copy link
Copy Markdown
Contributor Author

Added all five: POJO first element (toArray() returns TestBean[], toDynaBeanArray() returns WrapDynaBean[]), BasicDynaBean first element (both arrays typed to the subclass), addAll(Collection) and addAll(int, Collection) on an untyped list, get() growing after the first element fixes the type, and toDynaBeanArray() component type for the untyped map case. LazyDynaListTest is up to 21 tests, full mvn default goal green.

@garydgregory

Copy link
Copy Markdown
Member

@rootvector2 Please rebase on git master to resolve a test snafu.

@rootvector2
rootvector2 force-pushed the lazydynalist-element-type branch from 01bdbff to 4b1c340 Compare August 18, 2026 10:39
@rootvector2

Copy link
Copy Markdown
Contributor Author

Rebased on current master, full mvn default goal is green here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants